OpenSSL patch #2 - Test report of the modifications

Test Execution Status	Statistics
Passed	0.000% (0/43)
Incident	0.000% (0/43)
Skipped	0.000% (0/43)
Failed	0.000% (0/43)
Requires Manual Checking	0.000% (0/43)
Unknown	0.000% (0/43)
All	0.000% (0/43)

Category	Removed Lines	Inserted Lines	Total
Modified lines executed:	0.000% (0/12)	0.000% (0/12)	0.000% (0/24)
Modified lines not executed:	0.000% (0/12)	0.000% (0/12)	0.000% (0/24)
Source code lines not instrumented:	100.000% (12/12)	100.000% (12/12)	100.000% (24/24)

Showing: Headers Context

Line	Tests	Difference Output
		diff --git a/Configurations/00-base-templates.conf b/Configurations/00-base-templates.conf
		index 516e3cd525..dd0649d203 100644
		--- a/Configurations/00-base-templates.conf
		+++ b/Configurations/00-base-templates.conf
		@@ -45,7 +45,7 @@ my %targets=(
45		shared_extension => "",
46
47		#### Defaults for the benefit of the config targets who don't inherit
48	- No equivalent source code line in the reference code can be identified.	- #### a BASE and assume Unixly defaults
48	-	+ #### a BASE and assume Unix defaults
49		#### THESE WILL DISAPPEAR IN OpenSSL 1.2
50		build_scheme => [ "unified", "unix" ],
51		build_file => "Makefile",

Line	Tests	Difference Output
		diff --git a/Configurations/README b/Configurations/README
		index 6ae981f9aa..a03d445aea 100644
		--- a/Configurations/README
		+++ b/Configurations/README
		@@ -233,7 +233,7 @@ In each table entry, the following keys are significant:
233		apps, as needed by the target. This code
234		cannot be placed in a library, as the rest
235		of the code isn't expected to link to it
236	- No equivalent source code line in the reference code can be identified.	- explicitely.
236	-	+ explicitly.
237		cpuid_asm_src => assembler implementation of cpuid code as
238		well as OPENSSL_cleanse().
239		Default to mem_clr.c

Line	Tests	Difference Output
		diff --git a/Configurations/common0.tmpl b/Configurations/common0.tmpl
		index c0060095ba..03acb3e0b3 100644
		--- a/Configurations/common0.tmpl
		+++ b/Configurations/common0.tmpl
		@@ -16,7 +16,7 @@
16		? ()
17		: ( map { @{$unified_info{shared_sources}->{$_}} }
18		keys %{$unified_info{shared_sources}} ),
19	- No equivalent source code line in the reference code can be identified.	- # Things we explicitely depend on are usually generated
19	-	+ # Things we explicitly depend on are usually generated
20		( map { $_ eq "" ? () : @{$unified_info{depends}->{$_}} }
21		keys %{$unified_info{depends}} ));
22		our @generated =

Line	Tests	Difference Output
		diff --git a/INSTALL b/INSTALL
		index ff0aa6d127..4ce6651b6b 100644
		--- a/INSTALL
		+++ b/INSTALL
		@@ -614,8 +614,8 @@
614		Windows, and as a comma separated list of
615		libraries on VMS.
616		RANLIB The library archive indexer.
617	- No equivalent source code line in the reference code can be identified.	- RC The Windows resources manipulator.
618	- No equivalent source code line in the reference code can be identified.	- RCFLAGS Flags for the Windows reources manipulator.
617	-	+ RC The Windows resource compiler.
618	-	+ RCFLAGS Flags for the Windows resource compiler.
619		RM The command to remove files and directories.
620
621		These cannot be mixed with compiling / linking flags given
		@@ -969,7 +969,7 @@
969
970		BUILDFILE
971		Use a different build file name than the platform default
972	- No equivalent source code line in the reference code can be identified.	- ("Makefile" on Unixly platforms, "makefile" on native Windows,
972	-	+ ("Makefile" on Unix-like platforms, "makefile" on native Windows,
973		"descrip.mms" on OpenVMS). This requires that there is a
974		corresponding build file template. See Configurations/README
975		for further information.
		@@ -1171,7 +1171,7 @@
1171		part of the file name, i.e. for OpenSSL 1.1.x, 1.1 is somehow part of
1172		the name.
1173
1174	- No equivalent source code line in the reference code can be identified.	- On most POSIXly platforms, shared libraries are named libcrypto.so.1.1
1174	-	+ On most POSIX platforms, shared libraries are named libcrypto.so.1.1
1175		and libssl.so.1.1.
1176
1177		on Cygwin, shared libraries are named cygcrypto-1.1.dll and cygssl-1.1.dll
		@@ -1202,7 +1202,7 @@
1202		The seeding method can be configured using the --with-rand-seed option,
1203		which can be used to specify a comma separated list of seed methods.
1204		However in most cases OpenSSL will choose a suitable default method,
1205	- No equivalent source code line in the reference code can be identified.	- so it is not necessary to explicitely provide this option. Note also
1205	-	+ so it is not necessary to explicitly provide this option. Note also
1206		that not all methods are available on all platforms.
1207
1208		I) On operating systems which provide a suitable randomness source (in

Line	Tests	Difference Output
		diff --git a/apps/ca.c b/apps/ca.c
		index 48f7cd1973..847809a513 100644
		--- a/apps/ca.c
		+++ b/apps/ca.c
		@@ -605,7 +605,7 @@ end_of_options:
605		/*
606		* outdir is a directory spec, but access() for VMS demands a
607		* filename. We could use the DEC C routine to convert the
608	- No equivalent source code line in the reference code can be identified.	- * directory syntax to Unixly, and give that to app_isdir,
608	-	+ * directory syntax to Unix, and give that to app_isdir,
609		* but for now the fopen will catch the error if it's not a
610		* directory
611		*/

Line	Tests	Difference Output
		diff --git a/crypto/LPdir_unix.c b/crypto/LPdir_unix.c
		index 356089d7fd..b1022895c8 100644
		--- a/crypto/LPdir_unix.c
		+++ b/crypto/LPdir_unix.c
		@@ -51,7 +51,7 @@
51		#endif
52
53		/*
54	- No equivalent source code line in the reference code can be identified.	- * The POSIXly macro for the maximum number of characters in a file path is
54	-	+ * The POSIX macro for the maximum number of characters in a file path is
55		* NAME_MAX. However, some operating systems use PATH_MAX instead.
56		* Therefore, it seems natural to first check for PATH_MAX and use that, and
57		* if it doesn't exist, use NAME_MAX.

Line	Tests	Difference Output
		diff --git a/crypto/evp/e_aes.c b/crypto/evp/e_aes.c
		index f81ad66029..0901196e06 100644
		--- a/crypto/evp/e_aes.c
		+++ b/crypto/evp/e_aes.c
		@@ -2255,7 +2255,7 @@ static int s390x_aes_ccm_cipher(EVP_CIPHER_CTX ctx, unsigned char out,
2255
2256		if (!cctx->aes.ccm.len_set) {
2257		/*-
2258	- No equivalent source code line in the reference code can be identified.	- * In case message length was not previously set explicitely via
2258	-	+ * In case message length was not previously set explicitly via
2259		* Update(), set it now.
2260		*/
2261		ivec = EVP_CIPHER_CTX_iv_noconst(ctx);

Line	Tests	Difference Output
		diff --git a/e_os.h b/e_os.h
		index 5769029b72..8991e6202f 100644
		--- a/e_os.h
		+++ b/e_os.h
		@@ -245,7 +245,7 @@ extern FILE *_imp___iob;
245
246		Finally, we add the VMS C facility code 0x35a000, because there are some
247		programs, such as Perl, that will reinterpret the code back to something
248	- No equivalent source code line in the reference code can be identified.	- POSIXly. 'man perlvms' explains it further.
248	-	+ POSIX. 'man perlvms' explains it further.
249
250		NOTE: the perlvms manual wants to turn all codes 2 to 255 into success
251		codes (status type = 1). I couldn't disagree more. Fortunately, the

OpenSSL patch #2 - Test report of the modifications

Overview

List of tests executing the changes

Patch File

Modified File: Configurations/00-base-templates.conf

Modified File: Configurations/README

Modified File: Configurations/common0.tmpl

Modified File: INSTALL

Modified File: apps/ca.c

Modified File: crypto/LPdir_unix.c

Modified File: crypto/evp/e_aes.c

Modified File: e_os.h