OpenCoverageOpenSSL

OpenSSL patch #5 - Test report of the modifications

Overview

Test Execution StatusStatistics
Passed
  0.000% (0/43)
Incident
  0.000% (0/43)
Skipped
  0.000% (0/43)
Failed
  0.000% (0/43)
Requires Manual Checking
  0.000% (0/43)
Unknown
  2.326% (1/43)
All
  2.326% (1/43)
CategoryRemoved LinesInserted LinesTotal
Modified lines executed:
100.000% (15/15)
 82.353% (14/17)
 90.625% (29/32)
Modified lines not executed:
  0.000% (0/15)
  0.000% (0/17)
  0.000% (0/32)
Source code lines not instrumented:
  0.000% (0/15)
 17.647% (3/17)
  9.375% (3/32)

List of tests executing the changes

Execution NameState
libssl.so.1.1Unknown

Patch File

Showing: 

Modified File: ssl/statem/statem_srvr.c

LineTestsDifference Output
diff --git a/ssl/statem/statem_srvr.c b/ssl/statem/statem_srvr.c
index 346b1e3989..95f83c8462 100644
--- a/ssl/statem/statem_srvr.c
+++ b/ssl/statem/statem_srvr.c
@@ -2056,10 +2056,6 @@ static int tls_early_post_process_client_hello(SSL *s)
2056 #else
2057 s->session->compress_meth = (comp == NULL) ? 0 : comp->id;
2058 #endif
2059
1
Executed by:
  • libssl.so.1.1
- if (!tls1_set_server_sigalgs(s)) {
2060
1
Executed by:
  • libssl.so.1.1
- /* SSLfatal() already called */
2061
1
Executed by:
  • libssl.so.1.1
- goto err;
2062
1
Executed by:
  • libssl.so.1.1
- }
2063 ➡ 2059 }
2064 ➡ 2060
2065 ➡ 2061 sk_SSL_CIPHER_free(ciphers);
@@ -2227,19 +2223,25 @@ WORK_STATE tls_post_process_client_hello(SSL *s, WORK_STATE wst)
2227 ➡ 2223 if (wst == WORK_MORE_B) {
2228 ➡ 2224 if (!s->hit || SSL_IS_TLS13(s)) {
2229 ➡ 2225 /* Let cert callback update server certificates if required */
2230
1
Executed by:
  • libssl.so.1.1
- if (!s->hit && s->cert->cert_cb != NULL) {
2231
1
Executed by:
  • libssl.so.1.1
- int rv = s->cert->cert_cb(s, s->cert->cert_cb_arg);
2232
1
Executed by:
  • libssl.so.1.1
- if (rv == 0) {
2233
1
Executed by:
  • libssl.so.1.1
- SSLfatal(s, SSL_AD_INTERNAL_ERROR,
2234
1
Executed by:
  • libssl.so.1.1
- SSL_F_TLS_POST_PROCESS_CLIENT_HELLO,
2235
1
Executed by:
  • libssl.so.1.1
- SSL_R_CERT_CB_ERROR);
2236
1
Executed by:
  • libssl.so.1.1
- goto err;
2226
1
Executed by:
  • libssl.so.1.1
+ if (!s->hit) {
2227
1
Executed by:
  • libssl.so.1.1
+ if (s->cert->cert_cb != NULL) {
2228
1
Executed by:
  • libssl.so.1.1
+ int rv = s->cert->cert_cb(s, s->cert->cert_cb_arg);
2229
1
Executed by:
  • libssl.so.1.1
+ if (rv == 0) {
2230
1
Executed by:
  • libssl.so.1.1
+ SSLfatal(s, SSL_AD_INTERNAL_ERROR,
2231
1
Executed by:
  • libssl.so.1.1
+ SSL_F_TLS_POST_PROCESS_CLIENT_HELLO,
2232
1
Executed by:
  • libssl.so.1.1
+ SSL_R_CERT_CB_ERROR);
2233
1
Executed by:
  • libssl.so.1.1
+ goto err;
2234
-
+ }
2235
1
Executed by:
  • libssl.so.1.1
+ if (rv < 0) {
2236
1
Executed by:
  • libssl.so.1.1
+ s->rwstate = SSL_X509_LOOKUP;
2237
1
Executed by:
  • libssl.so.1.1
+ return WORK_MORE_B;
2238
-
+ }
2239
1
Executed by:
  • libssl.so.1.1
+ s->rwstate = SSL_NOTHING;
2237 ➡ 2240 }
2238
1
Executed by:
  • libssl.so.1.1
- if (rv < 0) {
2239
1
Executed by:
  • libssl.so.1.1
- s->rwstate = SSL_X509_LOOKUP;
2240
1
Executed by:
  • libssl.so.1.1
- return WORK_MORE_B;
2241
1
Executed by:
  • libssl.so.1.1
+ if (!tls1_set_server_sigalgs(s)) {
2242
-
+ /* SSLfatal already called */
2243
1
Executed by:
  • libssl.so.1.1
+ goto err;
2241 ➡ 2244 }
2242
1
Executed by:
  • libssl.so.1.1
- s->rwstate = SSL_NOTHING;
2243 ➡ 2245 }
2244 ➡ 2246
2245 ➡ 2247 /* In TLSv1.3 we selected the ciphersuite before resumption */

Generated by Squish Coco 4.2.2