Qt Quick patch #11 - Test report of the modifications

Test Execution Status	Statistics
Passed	0.000% (0/185)
Failed	0.000% (0/185)
Requires Manual Checking	0.000% (0/185)
Unknown	11.892% (22/185)
All	11.892% (22/185)

Category	Removed Lines	Inserted Lines	Total
Modified lines executed:	0.000% (0/9)	50.000% (2/4)	15.385% (2/13)
Modified lines not executed:	0.000% (0/9)	0.000% (0/4)	0.000% (0/13)
Source code lines not instrumented:	100.000% (9/9)	50.000% (2/4)	84.615% (11/13)

Execution Name	State
tst_ecmascripttests	Unknown
tst_examples	Unknown
tst_parserstress	Unknown
tst_qjsengine	Unknown
tst_qjsvalue	Unknown
tst_qjsvalueiterator	Unknown
tst_qqmlconsole	Unknown
tst_qqmlecmascript	Unknown
tst_qqmlenginedebugservice	Unknown
tst_qqmllistmodel	Unknown
tst_qqmllocale	Unknown
tst_qqmlqt	Unknown
tst_qqmlvaluetypeproviders	Unknown
tst_qqmlxmlhttprequest	Unknown
tst_qquickanimationcontroller	Unknown
tst_qquickgridview	Unknown
tst_qquicklayouts	Unknown
tst_qquicklistview	Unknown
tst_qquickpositioners	Unknown
tst_quicktestmainwithsetup	Unknown
tst_signalspy	Unknown
tst_testfiltering	Unknown

Line	Tests	Difference Output
		diff --git a/src/qml/compiler/qv4codegen.cpp b/src/qml/compiler/qv4codegen.cpp
		index 2f2832069..4b766accb 100644
		--- a/src/qml/compiler/qv4codegen.cpp
		+++ b/src/qml/compiler/qv4codegen.cpp
		@@ -2264,6 +2264,10 @@ void Codegen::handleConstruct(const Reference &base, ArgumentList *arguments)
2264		create.argv = calldata.argv;
2265		bytecodeGenerator->addInstruction(create);
2266		}
2267	22 Executed by: tst_ecmascripttests tst_examples tst_parserstress tst_qjsengine tst_qjsvalue tst_qjsvalueiterator tst_qqmlconsole tst_qqmlecmascript tst_qqmlenginedebugservice tst_qqmllistmodel tst_qqmllocale tst_qqmlqt tst_qqmlvaluetypeproviders tst_qqmlxmlhttprequest tst_qquickanimationcontroller tst_qquickgridview tst_qquicklayouts tst_qquicklistview tst_qquickpositioners tst_quicktestmainwithsetup tst_signalspy tst_testfiltering	+ if (base.isSuper())
2268	-	+ // set the result up as the thisObject
2269	1 Executed by: tst_ecmascripttests	+ Reference::fromAccumulator(this).storeOnStack(CallData::This);
2270	-	+
2267 ➡ 2271		_expr.setResult(Reference::fromAccumulator(this));
2268 ➡ 2272		}
2269 ➡ 2273

Line	Tests	Difference Output
		diff --git a/tests/auto/qml/ecmascripttests/TestExpectations b/tests/auto/qml/ecmascripttests/TestExpectations
		index b791596d9..eaf2a67fb 100644
		--- a/tests/auto/qml/ecmascripttests/TestExpectations
		+++ b/tests/auto/qml/ecmascripttests/TestExpectations
		@@ -2555,7 +2555,6 @@ language/expressions/prefix-increment/S11.4.4_A5_T4.js sloppyFails
2555		language/expressions/prefix-increment/S11.4.4_A5_T5.js fails
2556		language/expressions/prefix-increment/S11.4.4_A6_T3.js fails
2557		language/expressions/super/call-bind-this-value-twice.js fails
2558	- No equivalent source code line in the reference code can be identified.	-language/expressions/super/call-bind-this-value.js fails
2559 ➡ 2558		language/expressions/super/call-construct-invocation.js fails
2560 ➡ 2559		language/expressions/super/call-proto-not-ctor.js fails
2561 ➡ 2560		language/expressions/super/prop-dot-cls-null-proto.js fails
		@@ -2738,7 +2737,6 @@ language/module-code/instn-star-props-nrml-star_FIXTURE.js fails
2738 ➡ 2737		language/module-code/instn-star-star-cycle-2_FIXTURE.js fails
2739 ➡ 2738		language/module-code/instn-star-star-cycle-indirect-x_FIXTURE.js fails
2740 ➡ 2739		language/module-code/namespace/internals/own-property-keys-binding-types_FIXTURE.js fails
2741	- No equivalent source code line in the reference code can be identified.	-language/rest-parameters/with-new-target.js fails
2742 ➡ 2740		language/statements/async-function/cptn-decl.js fails
2743 ➡ 2741		language/statements/async-function/declaration-returns-promise.js fails
2744 ➡ 2742		language/statements/async-function/evaluation-body.js fails
		@@ -3056,10 +3054,7 @@ language/statements/class/scope-static-meth-paramsbody-var-open.js fails
3056 ➡ 3054		language/statements/class/scope-static-setter-paramsbody-var-open.js fails
3057 ➡ 3055		language/statements/class/static-method-gen-non-configurable-err.js fails
3058 ➡ 3056		language/statements/class/static-method-non-configurable-err.js fails
3059	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/binding.js fails
3060 ➡ 3057		language/statements/class/subclass/bound-function.js fails
3061	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/builtin-objects/Array/contructor-calls-super-multiple-arguments.js fails
3062	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/builtin-objects/Array/contructor-calls-super-single-argument.js fails
3063 ➡ 3058		language/statements/class/subclass/builtin-objects/Array/super-must-be-called.js fails
3064 ➡ 3059		language/statements/class/subclass/builtin-objects/ArrayBuffer/regular-subclassing.js fails
3065 ➡ 3060		language/statements/class/subclass/builtin-objects/ArrayBuffer/super-must-be-called.js fails
		@@ -3101,10 +3096,6 @@ language/statements/class/subclass/class-definition-null-proto-super.js fails
3101 ➡ 3096		language/statements/class/subclass/class-definition-null-proto-this.js fails
3102 ➡ 3097		language/statements/class/subclass/class-definition-superclass-generator.js fails
3103 ➡ 3098		language/statements/class/subclass/default-constructor-spread-override.js fails
3104	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/derived-class-return-override-with-empty.js fails
3105	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/derived-class-return-override-with-this.js fails
3106	- No equivalent source code line in the reference code can be identified.	-language/statements/class/subclass/derived-class-return-override-with-undefined.js fails
3107	- No equivalent source code line in the reference code can be identified.	-language/statements/class/super/in-constructor.js fails
3108 ➡ 3099		language/statements/class/super/in-methods.js fails
3109 ➡ 3100		language/statements/const/block-local-closure-get-before-initialization.js fails
3110 ➡ 3101		language/statements/const/block-local-use-before-initialization-in-declaration-statement.js fails

Qt Quick patch #11 - Test report of the modifications

Overview

List of tests executing the changes

Patch File

Modified File: src/qml/compiler/qv4codegen.cpp

Modified File: tests/auto/qml/ecmascripttests/TestExpectations